Skip to content

Removed the docs about Debug #12677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 23, 2019

The doc does nothing more than showing a composer install command and linking to a class on github.

#SymfonyHackathon

@wouterj wouterj changed the title Removed the docs about installing Debug Removed the docs about Debug Nov 23, 2019
@@ -3,6 +3,7 @@ Debugging a Class Loader

.. caution::

The ``DebugClassLoader`` from the ClassLoader component was deprecated
in Symfony 2.5 and removed in Symfony 3.0. Use the
:ref:`DebugClassLoader provided by the Debug component <component-debug-class-loader>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this old deprecation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may remove it ... but I think that keeping it (only in 3.4) is also OK.

@@ -3,6 +3,7 @@ Debugging a Class Loader

.. caution::

The ``DebugClassLoader`` from the ClassLoader component was deprecated
in Symfony 2.5 and removed in Symfony 3.0. Use the
:ref:`DebugClassLoader provided by the Debug component <component-debug-class-loader>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may remove it ... but I think that keeping it (only in 3.4) is also OK.

@wouterj
Copy link
Member Author

wouterj commented Nov 24, 2019

Redirection added, ready to merge imho

@OskarStark OskarStark added this to the 3.4 milestone Nov 26, 2019
@OskarStark
Copy link
Contributor

Thanks Wouter.

OskarStark added a commit that referenced this pull request Nov 26, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

Removed the docs about Debug

The doc does nothing more than showing a `composer install` command and linking to a class on github.

#SymfonyHackathon

Commits
-------

bd47ded Removed the Debug component
@OskarStark OskarStark merged commit bd47ded into symfony:3.4 Nov 26, 2019
@wouterj wouterj deleted the rm-debug-component branch November 26, 2019 21:46
OskarStark added a commit that referenced this pull request Nov 27, 2019
This PR was merged into the 4.3 branch.

Discussion
----------

Follow up to remove the debug component

Follows #12677

This will fix [Travis](https://travis-ci.org/symfony/symfony-docs/builds/617199238) to be 💚 again!

We need to check the following branches afterwards if there are some more occurences

Commits
-------

1ac16e1 Follow up to remove the debug component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants