-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WIP] Notifier Page #12678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[WIP] Notifier Page #12678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TheGarious are you still working on the component docs? |
If nobody work, i finish this pr |
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 2, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
Hi @TheGarious! Thanks for starting on documenting this feature. I've taken your commit and merged them with the work of other contributors to completely finish this guide in #13025 . As a result, this PR is now included in the new PR so I'm going to close this one. |
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 2, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 2, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 2, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 2, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 3, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 3, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 5, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
wouterj
added a commit
to wouterj/symfony-docs
that referenced
this pull request
Feb 5, 2020
This merges the work of symfony#12678, symfony#12846, symfony#12963 and finishes the main Notifier guide.
OskarStark
added a commit
that referenced
this pull request
Feb 6, 2020
…onin, savvasal, wouterj) This PR was merged into the 5.0 branch. Discussion ---------- [Notifier] Added Notifier guide This PR merges the work of our doc hero's @TheGarious, @andreybolonin and @savvasal in #12678, #12846 and #12963 . Fixes #12430 and fixes #12552 The component has 2 different usages: Using the high-level Notifier abstraction and using the lower-level Chatter and Texter abstractions. I decided to only document the high-lever in the main guide and use sub guides for Chatter and Texter. This PR focuses on having the base documentation ready. Some features (monolog & messenger integration) are not documented. Let's create issues for those and do them after this PR is merged. Commits ------- 69f3330 Improved some grammar thanks to @savvasal 06f7009 Add Notifier component documentation 0179303 Reorder the use statements alphabetically b9d0d7f Slack notifier actions documentation 34f23d0 add notifier.rst 4810fbf WIP Notifer Page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress, i need install and work with notifier components for finish documentation.
Contribute is open 💃