Add container.hot_path to built-in service tags #12684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
@glickel very nice contribution about something important which was missing in the docs. I left some minor comments. Congrats on your first Symfony Docs contribution!
|
@javiereguiluz thank you for your comment and feedbacks, normally all issues should be fixed. I should check twice before pushing :) |
OskarStark
reviewed
Nov 26, 2019
OskarStark
approved these changes
Nov 26, 2019
|
Thanks Gaetan for working on this feature, this is much appreciated. |
OskarStark
added a commit
that referenced
this pull request
Nov 26, 2019
This PR was merged into the 3.4 branch. Discussion ---------- Add container.hot_path to built-in service tags Related to [symfony/symfony#24872](symfony/symfony#24872) <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 1647b9a Add container.hot_path to built-in service tags
OskarStark
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to symfony/symfony#24872