Skip to content

uppercase #12707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

uppercase #12707

merged 1 commit into from
Nov 27, 2019

Conversation

erlangparasu
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Nov 27, 2019
javiereguiluz
javiereguiluz approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlangp your proposal is indeed better. Thanks!

Note to mergers: merge in 4.3.

@OskarStark OskarStark changed the base branch from 5.0 to 4.3 November 27, 2019 15:24
@OskarStark
Copy link
Contributor

Thank you @erlangp.

OskarStark added a commit that referenced this pull request Nov 27, 2019
@OskarStark
minor #12707 uppercase (erlangp)
f3bb355 
This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes #12707).

Discussion
----------

uppercase

Commits
-------

6ba282e uppercase
@OskarStark OskarStark merged commit 6ba282e into symfony:4.3 Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@erlangparasu @OskarStark @javiereguiluz @carsonbot