Removed constructor parameters from AuthenticationTrustResolver #12721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
I wasn't aware of this! Thanks a lot for fixing this @jzawadzki.
Note to mergers: this was deprecated in 4.2 (see https://github.com/symfony/symfony/pull/26981/files#diff-485d8e41d04a62846513306f98bc73f3R8) so, given the change, I propose to merge this in 4.3 to not use this deprecated feature in 4.3 and higher. Thanks.
09b208f to
f046117
Compare
|
Merged in 4.3. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Nov 30, 2019
…esolver (jzawadzki) This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes #12721). Discussion ---------- Removed constructor parameters from AuthenticationTrustResolver As per symfony/symfony#26981 there are no constructor arguments in `AuthenticationTrustResolver`. Commits ------- f046117 Removed constructor parameters from AuthenticationTrustResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per symfony/symfony#26981 there are no constructor arguments in
AuthenticationTrustResolver.