Skip to content

Update mailer.rst #12725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Update mailer.rst #12725

merged 1 commit into from
Dec 3, 2019

Conversation

atailouloute
Copy link
Contributor

No description provided.

javiereguiluz
javiereguiluz reviewed Dec 2, 2019
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

However, according to https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mailer/Bridge/Google/CHANGELOG.md we should also slightly update the namespace of the class:

...\Google\Smtp\GmailTransport -> ...\Google\Transport\GmailSmtpTransport

@javiereguiluz javiereguiluz added this to the 4.4 milestone Dec 2, 2019
@OskarStark
Copy link
Contributor

Good catch, thanks @atailouloute.

OskarStark added a commit that referenced this pull request Dec 3, 2019
@OskarStark
minor #12725 Update mailer.rst (atailouloute)
104780d 
This PR was squashed before being merged into the 4.4 branch (closes #12725).

Discussion
----------

Update mailer.rst

Commits
-------

627ec43 Update mailer.rst
@OskarStark OskarStark merged commit 627ec43 into symfony:4.4 Dec 3, 2019
@atailouloute atailouloute deleted the patch-26 branch December 3, 2019 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Mailer Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@atailouloute @OskarStark @javiereguiluz @carsonbot