Mention twig/extensions is not for Twig 3 #12737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also direct users to other (maintained) extensions like intl-extra or html-extra. |
As twig/extensions is obsolete according to: twigphp/Twig-extensions#258 And not compatible with Twig 3, let prevent developers for running a dead end command.
018fdfe to
3938b0a
Compare
javiereguiluz
added a commit
that referenced
this pull request
Dec 9, 2019
This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes #12737). Discussion ---------- Mention twig/extensions is not for Twig 3 As twig/extensions is obsolete according to: twigphp/Twig-extensions#258 And not compatible with Twig 3, let prevent developers for running a dead end command. Commits ------- 3938b0a Mention twig/extensions is not for Twig 3
|
@kylekatarnls thanks for this contribution! This was a good catch because we recently removed any mention of "official Twig extensions" (see #12739) but we forgot this one. Instead of mentioning that extensions are only for Twig 1 and 2, we've tweaked this while merging to make the change proposed by @pableu and mention the nex "Twig extra repositories". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As twig/extensions is obsolete according to:
twigphp/Twig-extensions#258
And not compatible with Twig 3, let prevent developers for running a dead end command.