[DependencyInjection] Bind tagged services #12741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Nov 30, 2019
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 30, 2019
…allowed in 'bind' tag (tienvx) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs/pull/12741 <!-- required for new features --> Add test case for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services and fix a bug with attribute 'tag' is not allowed Commits ------- e38f7d4 [DependencyInjection][Xml] Fix the attribute 'tag' is not allowed in 'bind' tag
There was a problem hiding this comment.
Thanks for this contribution! It's really nice, but it's missing a little detail: we need to add a versionadded directive to tell readers that this was added in Symfony 4.4.
So, please, update your pull request as follows: in line 742, just before the paragraph that starts with "By putting the bind key under _defaults ...", add the following:
.. versionadded:: 4.4
The feature to bind tagged services was introduced in Symfony 4.4.|
Thanks @tienvx for working on this feature, this is much appreciated. I added the versionadded directive for you 😃 |
OskarStark
added a commit
that referenced
this pull request
Dec 2, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Bind tagged services Update documentation for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services NOTE: this documentation require symfony/symfony#34732 to be merged Commits ------- 7ec6d9d [DependencyInjection] Bind tagged services
OskarStark
added a commit
that referenced
this pull request
Dec 2, 2019
|
That's quick :D Thanks very much! |
Thank you for this contribution 🎉 |
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Dec 2, 2019
* 4.4: Update parent_services.rst add versionadded directive. refs symfony#12741 Added article on password migrations [DependencyInjection] Bind tagged services Fix documentation for PhpUnitBridge regex configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for https://symfony.com/blog/new-in-symfony-4-4-dependency-injection-improvements-part-1#allow-binding-tagged-services
NOTE: this documentation require symfony/symfony#34732 to be merged