*Response::create() method is deprecated #12748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b4a675 to
c53c0af
Compare
c53c0af to
e930ea9
Compare
javiereguiluz
approved these changes
Dec 3, 2019
xabbuh
approved these changes
Dec 4, 2019
OskarStark
added a commit
that referenced
this pull request
Dec 4, 2019
This PR was merged into the 4.3 branch. Discussion ---------- *Response::create() method is deprecated @fabpot deprecated `*Response::create()` methods in symfony/symfony#34771 I think we can use `__construct` from the lowest version on (no occurences in `3.4`, so `4.3`) from now! No need to mention the deprecation itself in the docs IMHO Thats why I target `4.3` Commits ------- e930ea9 *Response::create() method is deprecated
|
It wasn't that big of a change anyway. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fabpot deprecated
*Response::create()methods in symfony/symfony#34771I think we can use
__constructfrom the lowest version on (no occurences in3.4, so4.3) from now!No need to mention the deprecation itself in the docs IMHO
Thats why I target
4.3