Skip to content

Document: get/setThrowable #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Document: get/setThrowable #12749

merged 1 commit into from
Dec 3, 2019

Conversation

OskarStark
Copy link
Contributor

Fixes #12615
Fixes #12716

@OskarStark OskarStark added this to the 4.4 milestone Dec 3, 2019
@OskarStark OskarStark self-assigned this Dec 3, 2019
@OskarStark OskarStark mentioned this pull request Dec 3, 2019
Closed
@OskarStark OskarStark changed the base branch from master to 4.4 December 3, 2019 11:22
@OskarStark
Copy link
Contributor Author

@javiereguiluz are you fine with deprecated and versionadded? I tried to only use deprecated one but the the „new“ is missing and less prominent, so I decided to go this way

@javiereguiluz
Copy link
Member

I agree. It looks like an edge case, so I like your solution!

OskarStark added a commit that referenced this pull request Dec 3, 2019
@OskarStark
minor #12749 Document: get/setThrowable (OskarStark)
7ef72fe 
This PR was merged into the 4.4 branch.

Discussion
----------

Document: get/setThrowable

Fixes #12615
Fixes #12716

Commits
-------

37a5f1e get/setThrowable
@OskarStark OskarStark merged commit 37a5f1e into symfony:4.4 Dec 3, 2019
@OskarStark OskarStark deleted the get-set-throwable branch December 3, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

+1 more reviewer

@atailouloute atailouloute atailouloute approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@OskarStark OskarStark

Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @javiereguiluz @atailouloute @carsonbot