[Form] Documented the choice_self_translation option of LanguageType #12750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 3, 2019
| @@ -74,6 +75,19 @@ If this option is ``true``, the choice values use the `ISO 639-2 alpha-3`_ | |||
| three-letter codes (e.g. French = ``fra``) instead of the default | |||
| `ISO 639-1 alpha-2`_ two-letter codes (e.g. French = ``fr``). | |||
|
|
|||
| choice_self_translation | |||
There was a problem hiding this comment.
By only looking at the option name I would not really know what this is supposed to do. Can we think of something more self-explanatory?
There was a problem hiding this comment.
I agree with you. I've updated the description. Is it more clear now? Thanks.
There was a problem hiding this comment.
I was rather thinking about renaming the option. But sadly I cannot come up with a better name. 😞
There was a problem hiding this comment.
But we can discuss that separately.
OskarStark
approved these changes
Dec 4, 2019
xabbuh
approved these changes
Dec 4, 2019
aab93dc to
7361fdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12745.