Minor tweak in a security expression explanation #12763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noniagriconomie
approved these changes
Dec 5, 2019
OskarStark
approved these changes
Dec 5, 2019
javiereguiluz
added a commit
that referenced
this pull request
Dec 7, 2019
…eguiluz) This PR was merged into the 3.4 branch. Discussion ---------- Minor tweak in a security expression explanation I was checking https://symfony.com/doc/current/security/expressions.html and I was going to submit a PR to fix this -> `"ROLE_ADMIN" in roles ...` But then I read that `roles` in expressions contains ALL roles (it "flattens" the role hierarchy) which is very different from what happens in other parts of Symfony. So maybe we could tweak the description a bit to make this special behavior more obvious? Commits ------- 8438276 Minor tweak in a security expression explanation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was checking https://symfony.com/doc/current/security/expressions.html and I was going to submit a PR to fix this ->
"ROLE_ADMIN" in roles ...But then I read that
rolesin expressions contains ALL roles (it "flattens" the role hierarchy) which is very different from what happens in other parts of Symfony. So maybe we could tweak the description a bit to make this special behavior more obvious?