Skip to content

Update injection_types.rst #12840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2020
Merged

Update injection_types.rst #12840

merged 1 commit into from
Jan 1, 2020

Conversation

boajer
Copy link
Contributor

@boajer boajer commented Dec 24, 2019

Typo fixed in the code snippet

OskarStark
OskarStark approved these changes Dec 24, 2019
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you very much! 😃

Merry Christmas 🎄

@xabbuh xabbuh added this to the 4.3 milestone Jan 1, 2020
@boajer @xabbuh
Update injection_types.rst
43f4422 
Typo fixed in the code snippet
@xabbuh xabbuh changed the base branch from 5.0 to 4.3 January 1, 2020 10:15
@xabbuh
Copy link
Member

xabbuh commented Jan 1, 2020

Thank you @boajer.

xabbuh added a commit that referenced this pull request Jan 1, 2020
@xabbuh
minor #12840 Update injection_types.rst (boajer)
08b34cb 
This PR was submitted for the 5.0 branch but it was merged into the 4.3 branch instead (closes #12840).

Discussion
----------

Update injection_types.rst

Typo fixed in the code snippet

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

43f4422 Update injection_types.rst
@xabbuh xabbuh merged commit 43f4422 into symfony:4.3 Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@boajer @xabbuh @OskarStark @carsonbot