[4.4][Security] Password migration with guards #12853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Dec 26, 2019
aab3785 to
ea43e0d
Compare
|
Thanks for the quick review, comments are fixed :) |
| namespace App\Security; | ||
|
|
||
| use Symfony\Component\Security\Guard\PasswordAuthenticatedInterface; | ||
| // ... |
There was a problem hiding this comment.
Missing the use of AbstractGuardAuthenticator no?
xabbuh
approved these changes
Jan 1, 2020
|
Thank you Wouter. |
xabbuh
added a commit
that referenced
this pull request
Jan 1, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [4.4][Security] Password migration with guards Fixes #12756 When using password migration with guard, you also need to implement an interface in your guard class. Thanks @chalasr for reporting this missing bit. Commits ------- ea43e0d Document PasswordAuthenticatedInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12756
When using password migration with guard, you also need to implement an interface in your guard class.
Thanks @chalasr for reporting this missing bit.