[Validator] added alpha3 option to country constraint #12857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazux
approved these changes
Dec 29, 2019
bf65a90 to
912a217
Compare
HeahDude
reviewed
Jan 17, 2020
| @@ -7,6 +7,7 @@ Validates that a value is a valid `ISO 3166-1 alpha-2`_ country code. | |||
| Applies to :ref:`property or method <validation-property-target>` | |||
| Options - `groups`_ | |||
| - `message`_ | |||
| - `alpha3`_ | |||
There was a problem hiding this comment.
We should keep an alpha order here
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jan 31, 2020
…axperrimond) This PR was squashed before being merged into the 5.1-dev branch (closes #35116). Discussion ---------- [Validator] Add alpha3 option to country constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#12857 A following of #33791 and #32988 to add `alpha3` option also to `Country` constraint in the validator component. Commits ------- d6f34a5 [Validator] Add alpha3 option to country constraint
wouterj
added a commit
that referenced
this pull request
Feb 9, 2020
…(maxperrimond) This PR was merged into the master branch. Discussion ---------- [Validator] added alpha3 option to country constraint <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Documentation part of symfony/symfony#35116 Commits ------- 912a217 [Validator] added alpha3 option to country constraint
wouterj
added a commit
that referenced
this pull request
Feb 9, 2020
|
Thanks for also taking care of the docs, @maxperrimond! Congratz on getting this merged in Symfony 5.1. Fyi, I've applied @HeahDude's comment and added a directive indicating this feature is new in d0e01b6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation part of symfony/symfony#35116