Skip to content

TransportFactoryInterface::createTransport signature is missing third… #12868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

TransportFactoryInterface::createTransport signature is missing third… #12868

wants to merge 0 commits into from

Conversation

carlosbuenosvinos
Copy link
Contributor

… mandatory SerializerInterface parameter

/**
 * Creates a Messenger transport.
 *
 * @author Samuel Roze <samuel.roze@gmail.com>
 */
interface TransportFactoryInterface
{
    public function createTransport(string $dsn, array $options, SerializerInterface $serializer): TransportInterface;

    public function supports(string $dsn, array $options): bool;
}

@javiereguiluz javiereguiluz added this to the 4.3 milestone Jan 2, 2020
@javiereguiluz
Copy link
Member

@carlosbuenosvinos thanks for this contribution! I'm sorry this was closed without merging! We use a proprietary tool to merge pull requests and an exception was thrown while merging (I also changed the base to 4.3 while trying to merge). The close was automatically done by this tool. I'm asking to other Symfony maintainers about this and I'll keep you posted about what could we do here. Thanks!

@javiereguiluz
Copy link
Member

After further investigation from @xabbuh, it looks like yesterday we merged a PR (#12835) which made the same changes ... so when merging this PR, the diff was empty and that's why the exception in our tool occurred and the automatic close happened.

So, I'm sorry for not having been aware of this before trying to merge this PR. And thanks again for your contribution Carlos, even if this time your PR was not merged because another older PR was merged to fix the same issue. Thanks!

@carlosbuenosvinos
Copy link
Contributor Author

Happy New year, @javiereguiluz! Thanks to you, it is such a pleasure to contribute whenever possible. I am using the Messenger a lot these days for a pet project and it is fantastic. Good job!

@carlosbuenosvinos carlosbuenosvinos deleted the patch-1 branch January 2, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosbuenosvinos @javiereguiluz @carsonbot