[Translation] Added tip about the incompatibility of % character #12949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jan 17, 2020
lyrixx
approved these changes
Jan 23, 2020
HeahDude
approved these changes
Jan 24, 2020
|
Thank you Mathieu. |
OskarStark
added a commit
that referenced
this pull request
Jan 30, 2020
…haracter (welcoMattic) This PR was submitted for the master branch but it was squashed and merged into the 4.3 branch instead (closes #12949). Discussion ---------- [Translation] Added tip about the incompatibility of % character With the ICU MessageFormat syntax, the character `%` is not valid anymore in parameter keys. It throws a `U_PATTERN_SYNTAX_ERROR` exception This fix must be backported on all versions from 4.2 included, since the introduction of IntlMessageFormatter <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 079ff73 [Translation] Added tip about the incompatibility of % character
OskarStark
added a commit
that referenced
this pull request
Jan 30, 2020
* 4.3: Minor Minor. refs #12949 [Translation] Added tip about the incompatibility of % character
OskarStark
added a commit
that referenced
this pull request
Jan 30, 2020
* 4.4: Minor Minor. refs #12949 [Translation] Added tip about the incompatibility of % character
OskarStark
added a commit
that referenced
this pull request
Jan 30, 2020
* 5.0: Minor Minor. refs #12949 [Translation] Added tip about the incompatibility of % character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the ICU MessageFormat syntax, the character
%is not valid anymore in parameter keys. It throws aU_PATTERN_SYNTAX_ERRORexceptionThis fix must be backported on all versions from 4.2 included, since the introduction of IntlMessageFormatter