Add Canonicalize option to Locale Constraint #12984
Conversation
|
@ro0NL can you please have a look here? Thanks! |
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
|
For 3.4 I guess? |
reference/constraints/Locale.rst
Outdated
| @@ -17,6 +17,7 @@ Applies to :ref:`property or method <validation-property-target>` | |||
| Options - `groups`_ | |||
| - `message`_ | |||
| - `payload`_ | |||
| _ `canonicalize`_ | |||
There was a problem hiding this comment.
@javiereguiluz shall we sort them in alpha order?
|
I remembered that this option was already documented. It was merged here: https://github.com/symfony/symfony-docs/pull/9248/files . So I don't understand how/when it was lost 🤔 |
Co-Authored-By: Oskar Stark <oskarstark@googlemail.com>
|
@javiereguiluz are you able to finalize this PR? |
|
This option was introduced in 4.1 by symfony/symfony#26075 as a backwards compatibility layer. In 4.1 setting it to anything different than We then correctly also removed this option from the Symfony 5.0+ docs in To me, it seems perfectly fine that this option is not documented in 5.0 and master. In the 4.4 version of the docs, this option is still visible: https://symfony.com/doc/4.4/reference/constraints/Locale#canonicalize For these reasons, I'm closing this PR. |
|
@wouterj where did we remove this in 5.x? 🤔 AFAIK only the default changed in between versions. |
Add Canonicalize option to Locale Constraint (which was added in Symfony 4.1: https://symfony.com/index.php/blog/new-in-symfony-4-1-validator-improvements)