Skip to content

[Mailer] add tag and metadata docs #13022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

[Mailer] add tag and metadata docs #13022

merged 1 commit into from
Feb 5, 2020

Conversation

kbond
Copy link
Member

@kbond kbond commented Jan 31, 2020

Q A
Target branch master/5.1
Issue closes #13017
Feature PR symfony/symfony#35050

OskarStark
OskarStark reviewed Jan 31, 2020
View reviewed changes
javiereguiluz
javiereguiluz approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Perfectly explained! Thanks Kevin.

@javiereguiluz javiereguiluz added this to the 5.1 milestone Feb 3, 2020
@OskarStark
Copy link
Contributor

OskarStark commented Feb 5, 2020 •
edited
Loading

Thanks Kevin for working on this feature, this is much appreciated. I reworded your work like this 1c67270

If you are not fine with it please let me know 👍 Thanks.

OskarStark added a commit that referenced this pull request Feb 5, 2020
@OskarStark
feature #13022 [Mailer] add tag and metadata docs (kbond)
7652386 
This PR was merged into the master branch.

Discussion
----------

[Mailer] add tag and metadata docs

| Q | A |
| --  | -- |
| Target branch | master/5.1 |
| Issue | closes #13017 |
| Feature PR | symfony/symfony#35050 |

Commits
-------

424f35a [mailer] add tag and metadata docs
@OskarStark OskarStark merged commit 424f35a into symfony:master Feb 5, 2020
OskarStark added a commit that referenced this pull request Feb 5, 2020
@OskarStark
Reword. refs #13022
1c67270
@kbond kbond deleted the mailer-tag-meta branch February 5, 2020 10:56
@javiereguiluz javiereguiluz mentioned this pull request May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Mailer Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

[Mailer] added tag/metadata support
4 participants
@kbond @OskarStark @javiereguiluz @carsonbot