Adjusts description of the csrf_token extension #13149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Feb 17, 2020
This PR was merged into the 4.4 branch. Discussion ---------- Adjusts description of the csrf_token extension I think using `...used to generate the token...` here leads to misunderstanding. The `intention` argument is not used to generate the csrf token. It is used to create a namespace string used to store and identify the token in the storage implementation. Commits ------- 44df761 Adjusts description of the csrf_token extension
|
Thanks Jan for this and the other related PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think using
...used to generate the token...here leads to misunderstanding.The
intentionargument is not used to generate the csrf token. It is used to create a namespace string used to store and identify the token in the storage implementation.