Remove the mention of TwigBundle\ExceptionController and extending doc #13222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ad44f3 to
a3a74c7
Compare
90365f6 to
dafce33
Compare
HeahDude
reviewed
Feb 23, 2020
OskarStark
approved these changes
Feb 23, 2020
|
Thanks Yonel! Do you think it makes sense to also document how to create your own error renderer? Or is that something that a user shouldn't do? Please create an issue if you want to have it documented, so we don't forget :) |
|
Hi @wouterj, thanks for merge! About your question, the error renderer layer is something internal and there is no extension point to add a new error renderer easily, besides doing that shouldn't be too common because we've I think there is no need to document how to create a new error renderer as long as there is no new error context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13071
Fixes #12920
I would no longer recommend to extend directly from
ErrorController. It adds a new error renderer layer that covers the most common error contexts (CLI, HTTP-html, HTTP-APIs), in the worst case you can decorare them, but it shouldn't be necessary.