Skip to content

[Form] added the "choice_filter" option #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2020
Merged

[Form] added the "choice_filter" option #13223

merged 1 commit into from
Apr 12, 2020

Conversation

HeahDude
Copy link
Contributor

Documentation for symfony/symfony#35733.

Based on #13182 for now, so better be reviewed by commit here until it's merged and rebased, thanks!

@HeahDude HeahDude added Form Waiting Code Merge Docs for features pending to be merged labels Feb 22, 2020
@HeahDude HeahDude added this to the next milestone Feb 22, 2020
@HeahDude HeahDude requested a review from xabbuh as a code owner February 22, 2020 17:30
@HeahDude HeahDude mentioned this pull request Feb 22, 2020
Merged
@HeahDude HeahDude force-pushed the feature/choice_filter branch from 7194302 to 526612c Compare February 22, 2020 17:34
@HeahDude HeahDude changed the title [Form] added the choice_filter option [Form] added the "choice_filter" option Feb 22, 2020
@HeahDude HeahDude force-pushed the feature/choice_filter branch 2 times, most recently from a2c2649 to 44b0d14 Compare February 22, 2020 17:48
fabpot added a commit to symfony/symfony that referenced this pull request Mar 16, 2020
@fabpot
feature #35733 [Form] Added a "choice_filter" option to ChoiceType (H…
e0bddee 
…eahDude)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Form] Added a "choice_filter" option to ChoiceType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Fix #32657
| License       | MIT
| Doc PR        | symfony/symfony-docs#13223

Finally opening this PR for a very old branch, based on both #34550 (merged) and #30994 (merged).

~Until #30994 is merged, this PR should better be reviewed by commits. Thanks!~

Commits
-------

ed2c312 [Form] Added a "choice_filter" option to ChoiceType
@HeahDude HeahDude removed the Waiting Code Merge Docs for features pending to be merged label Mar 16, 2020
@HeahDude HeahDude modified the milestones: next, 5.1 Mar 16, 2020
javiereguiluz
javiereguiluz approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @HeahDude do you consider it finished? Thanks!

@HeahDude HeahDude force-pushed the feature/choice_filter branch from 44b0d14 to 5314a87 Compare April 4, 2020 14:43
@HeahDude HeahDude force-pushed the feature/choice_filter branch from 5314a87 to b48c500 Compare April 12, 2020 14:24
@HeahDude HeahDude force-pushed the feature/choice_filter branch from b48c500 to 8b0c09e Compare April 12, 2020 14:45
@HeahDude HeahDude merged commit fe48efd into symfony:master Apr 12, 2020
@HeahDude HeahDude deleted the feature/choice_filter branch April 12, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@HeahDude @javiereguiluz @carsonbot