Skip to content

Shortening Doctrine Note #13439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Shortening Doctrine Note #13439

merged 1 commit into from
Apr 3, 2020

Conversation

ThomasLandauer
Copy link
Contributor

Follow up of #13437

@ThomasLandauer ThomasLandauer mentioned this pull request Mar 30, 2020
Merged
fabpot
fabpot reviewed Mar 30, 2020
View reviewed changes
ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Mar 30, 2020
@ThomasLandauer
Update form_collections.rst
6ef7b48 
See symfony#13439 (comment)
@xabbuh xabbuh added this to the 3.4 milestone Mar 30, 2020
@javiereguiluz javiereguiluz merged commit 0ddaf48 into symfony:3.4 Apr 3, 2020
@javiereguiluz
Copy link
Member

Thanks Thomas. At the end I removed this note entirely. We only said "We use Doctrine here" ... but we don't say that in the rest of Symfony Docs articles that use Doctrine ... so it's not needed here either. Thanks!

@ThomasLandauer
Copy link
Contributor Author

Sure, I already agreed in advance :-) #13437 (comment)

@ThomasLandauer ThomasLandauer deleted the patch-10 branch April 3, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ThomasLandauer @javiereguiluz @fabpot @xabbuh @carsonbot