Skip to content

Simplifying the code block #13446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Simplifying the code block #13446

wants to merge 3 commits into from

Conversation

ThomasLandauer
Copy link
Contributor

No description provided.

@ThomasLandauer
Copy link
Contributor Author

Sorry, don't know what this means at https://github.com/symfony/symfony-docs/runs/545435697 :

WARNING: Inline literal start-string without end-string.

Please help!

@javiereguiluz
Copy link
Member

In RST the code highlighting is not the same as in Markdown, so these changes are not correct.

The key here is the double :: in the last phrase before the code sample. Those :: tells RST that the following content is a code sample that must be highlighted with PHP. We could use the explicit .. code-block:: php too ... but we don't want to do that because there are too many PHP blocks. That's why we use the :: trick. Thanks!

ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Mar 30, 2020
@ThomasLandauer
Simplifying the code block
57b7a95 
Second attempt of symfony#13446
Still don't know what went wrong with the RST syntax (I did keep the `::` in the first commit last time), so I'm trying it step after step now.
@ThomasLandauer ThomasLandauer mentioned this pull request Mar 30, 2020
Merged
javiereguiluz added a commit that referenced this pull request Jun 30, 2020
@javiereguiluz
minor #13451 Simplifying the code block (ThomasLandauer)
6f15a96 
This PR was merged into the 4.4 branch.

Discussion
----------

Simplifying the code block

Second attempt of #13446
Still don't know what went wrong with the RST syntax (I did keep the `::` in the first commit last time), so I'm trying it step after step now.

Commits
-------

57b7a95 Simplifying the code block
ThomasLandauer added a commit to ThomasLandauer/symfony-docs that referenced this pull request Jun 30, 2020
@ThomasLandauer
Update form_collections.rst
4379342 
Simplifying the code block. Second part of symfony#13446
@ThomasLandauer ThomasLandauer mentioned this pull request Jun 30, 2020
Merged
javiereguiluz pushed a commit to ThomasLandauer/symfony-docs that referenced this pull request Jul 1, 2020
@ThomasLandauer @javiereguiluz
Update form_collections.rst
b41b378 
Simplifying the code block. Second part of symfony#13446
javiereguiluz added a commit that referenced this pull request Jul 1, 2020
@javiereguiluz
minor #13921 Update form_collections.rst (ThomasLandauer)
bdc6e9b 
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead.

Discussion
----------

Update form_collections.rst

Simplifying the code block. Second part of #13446

Commits
-------

b41b378 Update form_collections.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasLandauer @javiereguiluz @carsonbot