Skip to content

[Forms] Add empty_data to the form HiddenType #13458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

[Forms] Add empty_data to the form HiddenType #13458

merged 1 commit into from
Apr 1, 2020

Conversation

osavchenko
Copy link
Contributor

Fixes #13401.

@osavchenko osavchenko requested a review from xabbuh as a code owner March 31, 2020 09:53
@xabbuh xabbuh added this to the 3.4 milestone Mar 31, 2020
@xabbuh xabbuh added the Form label Mar 31, 2020
@javiereguiluz
Copy link
Member

Thank you Oleksandr.

@javiereguiluz javiereguiluz merged commit 0cda846 into symfony:3.4 Apr 1, 2020
@xabbuh
Copy link
Member

xabbuh commented Apr 1, 2020

Please note that I agree with this change, but that blindly using the empty_data option is not the general solution for the problem laid out in #13401. Furthermore, the empty_data option is available in all other form types too. So maybe someone would like to submit a PR syncing all of them?

@osavchenko osavchenko deleted the add-empty-data-to-the-hidden-field branch April 1, 2020 09:11
@osavchenko
Copy link
Contributor Author

@xabbuh I have a question about other options. Could you please advise me?

We have HiddenType which is inherited from FormType and of course, some options are missed here, but I have checked TextType which is also inherited from FormType and on TextType we can find missed inherited options too. So, should we document all inherited options even if it looks useless like a label for the hidden type or we should use some rules for documenting options?

@HeahDude
Copy link
Contributor

HeahDude commented Apr 2, 2020

ref #6265 (comment)

This was referenced Apr 2, 2020
Closed
Merged
@osavchenko
Copy link
Contributor Author

@HeahDude Your notice was about DEFAULT_PLACEHOLDER?

javiereguiluz added a commit that referenced this pull request Apr 3, 2020
@javiereguiluz
minor #13480 [Forms] fix displaying empty_data option for hidden fi…
1382170 
…eld (osavchenko)

This PR was merged into the 3.4 branch.

Discussion
----------

[Forms] fix displaying `empty_data` option for hidden field

I made a mistake on my previous PR #13458 which cause new issue #13471.

Fixes #13471.

Commits
-------

4a4d155 fix displaying `empty_data` option for hidden field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@osavchenko @javiereguiluz @xabbuh @HeahDude @carsonbot