Adding version option #13472
Adding version option #13472
Conversation
Added version option to setup selected version in doc
|
can someone check - CI brokes, but not by a PR fault ...? @fabpot I think, it will be good for newbies to add version option for a non-latest release docs |
|
@wow-apps I'm sorry about the CI errors. They have been fixed now (it's not necessary, but you can rebase this PR if you want to get rid of those errors). |
|
@javiereguiluz no worries. But I think, I should rebase, because it will be closed for merging without all steps passed |
There was a problem hiding this comment.
I do not think adding this is a good idea. We will frequently need to update this and I don't see a need for "encouraging" using a specific (older) version for a new project. My personal recommendation is to always go with the latest version anyway when starting a project. Updating to a next minor release is (mostly) safe thanks to BC promise and should be fairly easy during the initial development phases. If necessary one can decide to stop at next LTS for a slower update cycle and have the benefit of all current features.
|
@dbrumann You're right, that better to select the latest version for a new project but version 4.4 still supported and client can decide which version he needs... |
|
I don't like this, as versions in commands are already selected in LTS section, and every minor someone would has to change those commands. Information about If it's really needed, then composer commands should point version |
|
@wow-apps I get that there are use cases for picking older versions, but in my opinion the default should be the current version. How about instead, in between the paragraphs (L55) we add a tip that you can select a version during setup with the |
There was a problem hiding this comment.
It finally made click for me, why you make this change. It's only supposed for 4.4-docs and not supposed to be merged upwards, so that the docs reflect the current way of starting a project with the same version of the docs being viewed. That makes sense to me. Sorry, for not catching that sooner. In that case I would only suggest to change the version for the composer command.
|
Alexey, thanks and congrats on your first Symfony Docs contribution! Sorry it took us so long to merge. While merging, I updated the version numbers for each branch. Thanks! |
Added version option to setup selected version in doc