Skip to content

[Forms] fix displaying empty_data option for hidden field #13479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7,419 commits into from
Closed

[Forms] fix displaying empty_data option for hidden field #13479

wants to merge 7,419 commits into from

Conversation

osavchenko
Copy link
Contributor

I made a mistake on my previous PR #13458 which cause new issue #13471.

Fixes #13471.

javiereguiluz and others added 30 commits March 12, 2020 17:21
…t (javiereguiluz)

This PR was squashed before being merged into the master branch (closes #13050).

Discussion
----------

[Testing] Documented the changes in MailerAssertionsTrait

Fixes #13044.

Commits
-------

5b0590e [Testing] Documented the changes in MailerAssertionsTrait
…ous)

This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #12812).

Discussion
----------

Update Associations with fix code-block example

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

1985be6 Update Associations with fix code-block example
* 4.4:
  Update Associations with fix code-block example
* 5.0:
  Update Associations with fix code-block example
This PR was merged into the 5.0 branch.

Discussion
----------

[Testing] Fix broken link

Fix a broken link here : https://symfony.com/doc/current/testing.html#ajax-requests

Symfony/Component/BrowserKit/Client has been replaced by Symfony/Component/BrowserKit/AbstractBrowser in 5.0

Commits
-------

0117fe5 Fix broken link
* 5.0:
  Fix broken link
* 3.4:
  [FIX] Custom pool
* 4.4:
  [FIX] Custom pool
* 5.0:
  [FIX] Custom pool
* 3.4:
  Add missing prefix/xxxer
* 4.4:
  Add missing prefix/xxxer
* 5.0:
  Add missing prefix/xxxer
* 4.4:
  [Cache] fixed a bad merge
* 5.0:
  [Cache] fixed a bad merge
…ments (Ioni14)

This PR was merged into the 4.4 branch.

Discussion
----------

Remove caution section about bind scalar controller arguments

This caution section is no longer relevant since 4.1 with symfony/symfony@2c7198c .

Commits
-------

717547b Remove caution section about bind scalar controller arguments
* 4.4:
  Remove caution section about bind scalar controller arguments
* 5.0:
  Remove caution section about bind scalar controller arguments
…bogusz)

This PR was squashed before being merged into the master branch (closes #13316).

Discussion
----------

[Form] Add description of label_html option

| Q             | A
| ------------- | ---
| Feature PR      | symfony/symfony#31375
| PR author(s)      | @przemyslaw-bogusz
| Merged in  | WCM

Commits
-------

7a74bb3 [Form] Add description of label_html option
…erface (vadim2991)

This PR was merged into the 4.4 branch.

Discussion
----------

fix Mercure PublisherStub should be implement PublisherInterface

Commits
-------

598f1c1 fix Mercure PublisherStub should be implement PublisherInterface
* 4.4:
  fix Mercure PublisherStub should be implement PublisherInterface
* 5.0:
  fix Mercure PublisherStub should be implement PublisherInterface
* 3.4:
  [Form] Better explicit cloning with "by_reference" option
* 4.4:
  [Form] Better explicit cloning with "by_reference" option
* 5.0:
  [Form] Better explicit cloning with "by_reference" option
javiereguiluz and others added 26 commits March 31, 2020 17:16
* 4.4:
  Update setup.rst - Friendlier phrasing for people choosing not to use th Symfony CLI
* 5.0:
  Update setup.rst - Friendlier phrasing for people choosing not to use th Symfony CLI
…erj)

This PR was merged into the 4.4 branch.

Discussion
----------

No longer list the Symfony binary as a requirement

Based on the same Slack discussion as #13461, I think we should also change this section a little bit.

Instead of listing it as a requirement (and then in the next sections, mention ways to do things without Symfony CLI), I think it's more fair to mention it as a highly recommended tool instead.

Commits
-------

dfe0cf8 No longer list the Symfony binary as a requirement
* 4.4:
  No longer list the Symfony binary as a requirement
* 5.0:
  No longer list the Symfony binary as a requirement
* 3.4:
  Rephrasing the "If you render your whole" note (2nd attempt)
  add empty_data to the form HiddenType
* 4.4:
  Rephrasing the "If you render your whole" note (2nd attempt)
  add empty_data to the form HiddenType
* 5.0:
  Rephrasing the "If you render your whole" note (2nd attempt)
  add empty_data to the form HiddenType
* 4.4:
  Removed an unused link
* 5.0:
  Removed an unused link
In the entity listener section, the PHP config docs were using the event_listener tag instead.
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13473).

Discussion
----------

Tag name updated

In the entity listener section, the PHP config docs were using the event_listener tag instead.

Commits
-------

5577f7b Tag name updated
* 4.4:
  Tag name updated
* 5.0:
  Tag name updated
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13476).

Discussion
----------

Missing closing tag for endblock.

Missing %} statement added

Commits
-------

2f2cf6b Missing closing tag for endblock.
* 4.4:
  Missing closing tag for endblock.
* 5.0:
  Missing closing tag for endblock.
…thout autoconfiguration (pounard)

This PR was merged into the 4.4 branch.

Discussion
----------

Fixes wrong tag for RouteLoaderInterface registration without autoconfiguration

Following #13474

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

13a92be Fixes wrong tag for RouteLoaderInterface registration without autoconfiguration
* 4.4:
  Fixes wrong tag for RouteLoaderInterface registration without autoconfiguration
* 5.0:
  Fixes wrong tag for RouteLoaderInterface registration without autoconfiguration
@osavchenko osavchenko requested a review from xabbuh as a code owner April 2, 2020 17:16
@osavchenko osavchenko closed this Apr 2, 2020
@osavchenko osavchenko deleted the fix__empty_data_on_hidden branch April 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.