Skip to content

Update definitions.rst #13503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Update definitions.rst #13503

merged 3 commits into from
Apr 10, 2020

Conversation

st-pham
Copy link
Contributor

@st-pham st-pham commented Apr 6, 2020

Addition of function 'setArgument'

The code was added in commit: symfony@a2c04e7

The change introducing the issue was added in the PR: symfony#12075
javiereguiluz and others added 2 commits April 10, 2020 15:09
…deprecated class (fsoedjede)

This PR was merged into the 3.4 branch.

Discussion
----------

[Contributing] Fix `trigger_error()` position in deprecated class

The code was added in commit: symfony@a2c04e7

The change introducing the issue was added in the PR: symfony#12075

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

0dc5efc [Contributing] Fix `trigger_error()` position in deprecated class
Addition of function 'setArgument'
@javiereguiluz javiereguiluz changed the base branch from 5.0 to 3.4 April 10, 2020 13:14
@javiereguiluz
Copy link
Member

@tungps0811 thanks ... and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit e68834e into symfony:3.4 Apr 10, 2020
@st-pham st-pham deleted the patch-1 branch March 16, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants