Skip to content

[Contributing] Fix trigger_error() position in deprecated class #13504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[Contributing] Fix trigger_error() position in deprecated class #13504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contributing/code/conventions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ the Web Debug Toolbar or by the PHPUnit bridge).
.. _`@-silencing operator`: https://php.net/manual/en/language.operators.errorcontrol.php

When deprecating a whole class the ``trigger_error()`` call should be placed
between the namespace and the use declarations, like in this example from
after the use declarations, like in this example from
`ServiceRouterLoader`_::

namespace Symfony\Component\Routing\Loader\DependencyInjection;
Expand Down