Skip to content

Corrects description for placement of trigger_deprecation() #13510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Corrects description for placement of trigger_deprecation() #13510

wants to merge 1 commit into from

Conversation

pjio
Copy link

@pjio pjio commented Apr 8, 2020

No description provided.

@wouterj
Copy link
Member

wouterj commented Apr 10, 2020

Hi @pjio! Thanks a lot for taking the time to submit a fix. However, someone already sent the same fix a day before you did in #13504 . So I'm very sorry, but I'm going to close this PR in favor of that one.

Hope to see you back in the future with more fixes!

@wouterj wouterj closed this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jmsche jmsche jmsche approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjio @wouterj @jmsche @carsonbot