-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Explain host per locale #13571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain host per locale #13571
Conversation
bcd0ef1
to
e5b3fff
Compare
e5b3fff
to
f82ea72
Compare
@javiereguiluz Would it be a good idea to link blog post to new features like this? They are insightful sometime and they may give more example. They may be outdated too perhaps? |
@B-Galati in some posts we link to the related Symfony Docs ... but for unmerged PRs, we very rarely do that because of their uncertainty (will they be merged? will they be replaced by other PRs? etc.) |
Sorry I did not explain myself correctly. I meant having links in the doc that would point to the blog post where the feature has been highlighted. |
Sounds like a good idea IMO and in both ways: Blog post -> documentation: Once you remind a feature you heard about thanks to blog posts you have to dig into the documentation to have more information. For this reason, having a link to the documentation in the blog posts could be useful. On the other hand, it can lead to dead links when the documentation move which is definitively not useful at all. Furthermore, as you said @javiereguiluz, documentation is generally not (yet) available online when a blog post is published. Documentation -> Blog post: Having a link to the blog post from the documentation is also useful: you can sometimes find a bit more information regarding the context of the feature / improvement (the "Why?") instead of "just" having the detailed explanations (the "How?"). The only drawback I can think about may be the readability: too much links to blog posts could be counter productive but it's probably easily avoidable. That's said, it's just the opinion on someone who don't contribute to the documentation! xD |
I disagree with the proposal to link to blog posts. The reason is that blog posts are "volatile" and "out of context" (each post is independent, it doesn't take into account versioning, deprecated features, etc.), while docs are designed to be "perpetual and contextual". Besides, posts and docs talk about the same/similar things, so we would just create confusion with this duplication. |
This PR has been closed because the master has been removed. |
This PR was squashed before being merged into the 5.2 branch. Discussion ---------- [Routing] Explain host per locale <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `5.x` for features of unreleased versions). --> Reopens #13571 initially opened by `@odolbeau` but staled for a while then closed when removing master branch. This is just a copy/paste from the inital PR. Documents feature: symfony/symfony#36187 Closes #13572 Commits ------- ebb266c [Routing] Explain host per locale
Feature: symfony/symfony#36187
Fix #13572