[Notifier] Add FreeMobile SMS entry #13600
Conversation
There was a problem hiding this comment.
Just a question as I am not sure where and how to document the fact that this sms notifier is a bit special, is it ok like this in the versionadded code block?
I always approach versionadded blocks as things that can be deleted without thinking about the contents. So we should not be loosing information when deleting them. I would say add a .. note:: after telling what makes FreeMobile so special (is there a reason btw to make it special? Can't it set the phone number dynamically?)
|
@wouterj ok lets add a note then
This french phone provider allow to send free sms to your personal phone number edit: personal account :s |
|
I'm not sure about adding that note about Free Mobile. It's an internal detail of this service. Yes, I know it's important that you cannot send SMS but to yourself ... but what are the chances of being a client of that company and not knowing that? |
|
@javiereguiluz I see your point, maybe in the code itself then instead of the documentation? |
|
@noniagriconomie yes! Hopefully, in the code, we can return a perfect error message when someone tries to send a SMS to explain them that you can only send SMS to yourself. |
|
Thanks Antoine. |
This PR was merged into the 5.2-dev branch. Discussion ---------- [Notifier] add doc for free mobile dsn | Q | A | ------------- | --- | Branch? | master (maybe 5.1 ? it is only code doc) | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix symfony/symfony-docs#13600 (comment) | License | MIT | Doc PR | Improve readme according to the linked comment I've taken info of my original PR #35690 (with some rewrite) Also the package was renamed, fixing the doc here symfony/symfony-docs#14057 Commits ------- eb067ed [Notifier] add doc for free mobile dsn
Hi,
I was reading this blog post
and remind I have not yet added it to the doc this feature
Just a question as I am not sure where and how to document the fact that this sms notifier is a bit special, is it ok like this in the
versionadded code block?or maybe it is better in a note afterward?
Thank you