[Notifier] Add Infobip #13623
Merged
[Notifier] Add Infobip #13623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 10, 2020
This PR was squashed before being merged into the 5.2-dev branch. Discussion ---------- [Notifier] Add Infobip bridge | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#13623 - [x] Remove default host Add Infobip SMS. see https://www.infobip.com Commits ------- e138cba [Notifier] Add Infobip bridge
16883e2 to
f54b53b
Compare
|
Thank you Jérémy. |
OskarStark
reviewed
Sep 10, 2020
| @@ -63,6 +63,7 @@ OvhCloud ``symfony/ovhcloud-notifier`` ``ovhcloud://APPLICATION_KEY:APPL | |||
| Sinch ``symfony/sinch-notifier`` ``sinch://ACCOUNT_ID:AUTH_TOKEN@default?from=FROM`` | |||
| FreeMobile ``symfony/free-mobile-notifier`` ``freemobile://LOGIN:PASSWORD@default?phone=PHONE`` | |||
| Smsapi ``symfony/smsapi-notifier`` ``smsapi://TOKEN@default?from=FROM`` | |||
| Infobip ``symfony/infobip-notifier`` ``infobip://TOKEN@default?from=FROM`` | |||
There was a problem hiding this comment.
We should sort them alphabetically in a separate PR.
Same for the mailer transports.
Are you open for a PR @jeremyFreeAgent
And thanks for your contribution 🥳
There was a problem hiding this comment.
Done in #14211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for symfony/symfony#36480