Move HTTP client docs from components to guides #13916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
commented
Jun 28, 2020
|
|
||
| Performance |
There was a problem hiding this comment.
This diff is a bit messed-up: I moved the Performance (+ cURL support) a bit down. No contents where actually removed
2e3566e to
029681f
Compare
029681f to
9a51b28
Compare
|
Thanks for your detailed review @javiereguiluz! I fully agree with you that the order was a bit messed-up. I did some reordering and better explanation about the configuration. Please have a look again :) |
9a51b28 to
242b4d0
Compare
javiereguiluz
approved these changes
Jun 30, 2020
242b4d0 to
619e030
Compare
|
Merged! Thanks Wouter! |
|
This is now merged up to master. There were some conflicts in 5.1. Please check if I reworded things right to mention AmpHttp support. Also, this paragraph needs review: Is this correct ... or does Amp also support HTTP/2 push? Always or only in certain versions? Thanks! |
|
Amp supports push yes, for all versions listed in the composer.json file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component docs are actually very similar to the framework guide :). The biggest update is adding framework config examples to all examples showing global configuration and moving the framework integration section more to the start of the article.
We once added
php-standaloneandphp-symfonytabs to the configuration blocks, which allow showing the same code for standalone and in-framework usage. This currently is used only in the Form component docs: https://symfony.com/doc/current/components/form.html#creating-a-simple-form I heavily used this in the article, so we can show both code examples in a concise matter.Please let me know what you think! :)