Skip to content

[Doctrine] Fixed bad method name for example #13920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

francisbesset
Copy link
Contributor

This PR fix a bad method name in an example.

@javiereguiluz
Copy link
Member

@francisbesset thanks for this. However ... this is a bit tricky. The config example is only an optional config option ("if you want, use a custom method name") so it's not directly related to the example above. But I can see why that can be confusing. Let me think of an alternative solution for this.

@javiereguiluz javiereguiluz self-assigned this Jun 30, 2020
@francisbesset
Copy link
Contributor Author

Thank you for your answer.

I understand, however the PHP code and the configuration are in same chapter section.
If I copy paste two parts, the method name mismatch.

I trust you to find the best solution. 🙏

@javiereguiluz javiereguiluz merged commit 5005509 into symfony:4.4 Jul 1, 2020
@javiereguiluz javiereguiluz added this to the 4.4 milestone Jul 1, 2020
@javiereguiluz
Copy link
Member

At the end I commented the optional options: 3d04404 and made more clear the distinction between the mandatory options and the optional ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants