Skip to content

Improve profiler #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

Improve profiler #13944

merged 1 commit into from
Jul 9, 2020

Conversation

noniagriconomie
Copy link
Contributor

Small note improvement for the profiler logic with non html response
Also update the screenshot

@javiereguiluz
Copy link
Member

I like the note ... but I'd prefer to not change the screenshot. The original one shows the entire chart better ... and we only use the original light theme in screenshots. Thanks for understanding 🙏

@noniagriconomie
Copy link
Contributor Author

@javiereguiluz understood, screenshot rollbacked :)

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jul 9, 2020
@javiereguiluz javiereguiluz changed the base branch from master to 4.4 July 9, 2020 09:25
@javiereguiluz javiereguiluz merged commit f6435e3 into symfony:4.4 Jul 9, 2020
@javiereguiluz
Copy link
Member

Thanks Antoine! Merged in 4.4 and up.

@noniagriconomie noniagriconomie deleted the improve-profiler branch July 9, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Profiler Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@noniagriconomie @javiereguiluz @carsonbot