Use "closure-style" PHP configuration format in code examples #13965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic contribution! I love it!! Thanks a lot Marco. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we still use the "old" way of defining configuration in PHP in some code examples even though the new format has been available for quite a few years now: https://symfony.com/blog/new-in-symfony-3-4-php-based-configuration-for-services-and-routes
Seeing two styles of writing configuration in PHP might be confusing for beginners, so I've updated the examples here to use the new format.
There's probably still a number of places where the older format is used - I'll be sure to submit more PRs as I encouter them :)