Skip to content

[Stopwatch] Add name property to the stopwatchEvent #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2020
Merged

[Stopwatch] Add name property to the stopwatchEvent #14000

merged 1 commit into from
Sep 12, 2020

Conversation

AhmedRaafat14
Copy link
Contributor

@AhmedRaafat14 AhmedRaafat14 commented Jul 27, 2020 •
edited
Loading

Q A
Branch? master for features
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #14051

@AhmedRaafat14 AhmedRaafat14 changed the title Add name property to the stopwatchEvent [Stopwatch] Add name property to the stopwatchEvent Jul 27, 2020
@xabbuh xabbuh added this to the next milestone Aug 3, 2020
@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Aug 3, 2020
@AhmedRaafat14 AhmedRaafat14 changed the title [Stopwatch] Add name property to the stopwatchEvent [Stopwatch]Rename $name & $category varaibles Aug 11, 2020
@AhmedRaafat14 AhmedRaafat14 changed the title [Stopwatch]Rename $name & $category varaibles [Stopwatch] Add name property to the stopwatchEvent Aug 11, 2020
noniagriconomie
noniagriconomie approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably as well update the PR desc to also mentioned fix https://github.com/symfony/symfony-docs/issues/14051
:)

@AhmedRaafat14
Copy link
Contributor Author

@noniagriconomie Updated thanks :)

OskarStark
OskarStark requested changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a versionadded directive 👍🏻

@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label Aug 17, 2020
@xabbuh xabbuh modified the milestones: next, 5.2 Aug 17, 2020
@javiereguiluz
Copy link
Member

Ahmad, thanks and congrats on your first Symfony Docs contribution! It was a nice issue number too --> #14000

@OskarStark I added the versionadded directive while merging.

@javiereguiluz javiereguiluz merged commit 27fa9ef into symfony:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark requested changes

@noniagriconomie noniagriconomie noniagriconomie approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Stopwatch
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Stopwatch] Add name property to the stopwatchEvent
6 participants
@AhmedRaafat14 @javiereguiluz @OskarStark @noniagriconomie @xabbuh @carsonbot