Skip to content

fix link to ChainAdapter::prune method #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2020
Merged

fix link to ChainAdapter::prune method #14136

merged 1 commit into from
Aug 31, 2020

Conversation

pableu
Copy link
Contributor

@pableu pableu commented Aug 27, 2020

The link doesn't work otherwise.

maxhelias
maxhelias approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in 3.4

@pableu
Copy link
Contributor Author

pableu commented Aug 28, 2020

Should I make the PR against another branch?

@OskarStark OskarStark added this to the 3.4 milestone Aug 28, 2020
@maxhelias
Copy link
Contributor

No this can be changed during the merge

@javiereguiluz javiereguiluz changed the base branch from master to 3.4 August 31, 2020 07:19
@javiereguiluz
Copy link
Member

Merged in 3.4! Thanks Pablo.

@javiereguiluz javiereguiluz merged commit 30f2cf7 into symfony:3.4 Aug 31, 2020
@pableu pableu deleted the patch-1 branch September 1, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@maxhelias maxhelias maxhelias approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Cache Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@pableu @maxhelias @javiereguiluz @xabbuh @OskarStark @carsonbot