Skip to content

[Form] Added documentation for "html5" option of MoneyType and PercentType #14295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

[Form] Added documentation for "html5" option of MoneyType and PercentType #14295

merged 1 commit into from
Oct 2, 2020

Conversation

romaricdrigon
Copy link
Contributor

Hello,

Following symfony/symfony/pull/35956, which was merged for 5.2, this PR adds the corresponding documentation.

@javiereguiluz
Copy link
Member

Thanks! ... but there was already a PR for this: #14285. We'll merge the best changes of both proposals.

@javiereguiluz javiereguiluz added this to the 5.2 milestone Sep 28, 2020
@romaricdrigon
Copy link
Contributor Author

Thanks! ... but there was already a PR for this: #14285. We'll merge the best changes of both proposals.

Err, I totally missed it!
I think the mention about the "HTML5 number format" is not quite needed, as its is an internal format. Browser could decide to tweak the format presented to the user, in example according to browser locale. I don't think I ever saw it, but in theory, that's possible.

@javiereguiluz javiereguiluz merged commit b748085 into symfony:master Oct 2, 2020
@javiereguiluz
Copy link
Member

Romaric, at the end we merged your pull request (with a minor tweak) because it was better than the other PR. Thanks!

@romaricdrigon romaricdrigon deleted the feat-html5-option branch October 2, 2020 13:25
This was referenced Oct 2, 2020
Closed
Closed
@romaricdrigon
Copy link
Contributor Author

Romaric, at the end we merged your pull request (with a minor tweak) because it was better than the other PR. Thanks!

Thanks you!
And I forgot to say it, but thank you very much for the other PR, fixing stuff I forgot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@romaricdrigon @javiereguiluz @carsonbot