Skip to content

[Serializer] add note on Custom Normalizer page about cacheable performance #14328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

maxhelias
Copy link
Contributor

Fix #12061

@maxhelias maxhelias changed the base branch from master to 4.4 October 4, 2020 02:13
@maxhelias maxhelias force-pushed the serializer-cacheable branch from d6b6252 to 3e4c1dd Compare October 4, 2020 02:18
@wouterj wouterj added this to the 4.4 milestone Oct 4, 2020
@wouterj
Copy link
Member

wouterj commented Oct 4, 2020

If I understand this correctly, this section only makes sense when creating a custom normalizer (as the build-in normalizers already implement this). Is there a reason to keep this section in /serializer, or should we instead only put it in /serializer/custom_normalizers?

@maxhelias
Copy link
Contributor Author

Indeed yes, after it's always interesting to know it. Tell me, what do you prefer?

@maxhelias
Copy link
Contributor Author

@wouterj what would you like to do with this ? move all in the custom normalizer or keep it as it is ?

@wouterj
Copy link
Member

wouterj commented Nov 8, 2020

Sorry, I somehow missed your reaction. Yes, I'm in favor of moving the performance section to the custom normalizer article.

@maxhelias maxhelias force-pushed the serializer-cacheable branch from 3e4c1dd to ef9105e Compare November 9, 2020 10:12
@carsonbot carsonbot changed the title [Serializer] add note on Custom Normalizer page about cacheable performance [Serializer] add note on Custom Normalizer page about cacheable performance Nov 9, 2020
@maxhelias maxhelias force-pushed the serializer-cacheable branch from ef9105e to 6d51c6c Compare November 9, 2020 10:15
@carsonbot carsonbot changed the title [Serializer] add note on Custom Normalizer page about cacheable performance [Serializer] add note on Custom Normalizer page about cacheable performance Nov 9, 2020
@OskarStark OskarStark changed the title [Serializer] add note on Custom Normalizer page about cacheable performance [Serializer] add note on Custom Normalizer page about cacheable performance Nov 19, 2020
@javiereguiluz
Copy link
Member

Maxime, thanks for improving this. I'm sorry it took us so long to merge.

@javiereguiluz javiereguiluz merged commit b556f4f into symfony:4.4 Jan 22, 2021
@maxhelias maxhelias deleted the serializer-cacheable branch January 22, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention CacheableSupportsMethodInterface in "Create your own Normalizer"
4 participants