Skip to content

Enclose a value with ampersands in single quotes #14392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2020
Merged

Enclose a value with ampersands in single quotes #14392

merged 1 commit into from
Oct 14, 2020

Conversation

Chi-teck
Copy link
Contributor

@Chi-teck Chi-teck commented Oct 12, 2020 •
edited
Loading

This assignment does not work in bash becacuse & has special meaning.
SYMFONY_DEPRECATIONS_HELPER=max[total]=42&max[self]=0&verbose=0

@OskarStark
Copy link
Contributor

@greg0ire can you please verify this PR? Thanks

greg0ire
greg0ire approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct:

a=foo&bar
[1] 3789
bash: bar: command not found...

a=foo&bar
zsh: parse error near `&'

@wouterj wouterj changed the base branch from 5.x to 4.4 October 14, 2020 11:47
@wouterj wouterj force-pushed the symfony-deprecations-helper branch from b1930b2 to 23164fe Compare October 14, 2020 11:47
@wouterj
Copy link
Member

wouterj commented Oct 14, 2020

Thank you for testing & fixing this example, @Chi-teck!

@wouterj wouterj merged commit e9d169c into symfony:4.4 Oct 14, 2020
@xabbuh xabbuh added this to the 4.4 milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Chi-teck @OskarStark @wouterj @greg0ire @xabbuh @carsonbot