Skip to content

[Notifier] Add documentation for telegram options #14503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

[Notifier] Add documentation for telegram options #14503

merged 1 commit into from
Dec 8, 2020

Conversation

CyberJack
Copy link

Add documentation about Telegram options (issue #14044)

@wouterj wouterj linked an issue Oct 31, 2020 that may be closed by this pull request
[Notifier] added telegram options #14044
Closed
@wouterj wouterj added this to the 5.2 milestone Oct 31, 2020
wouterj
wouterj reviewed Oct 31, 2020
View reviewed changes
@CyberJack CyberJack requested a review from wouterj November 9, 2020 08:38
@xabbuh xabbuh changed the base branch from 5.x to 5.2 November 17, 2020 10:04
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Dec 7, 2020
@carsonbot carsonbot changed the title Add documentation for telegram options [Notifier] Add documentation for telegram options Dec 7, 2020
OskarStark
OskarStark reviewed Dec 7, 2020
View reviewed changes
OskarStark
OskarStark reviewed Dec 7, 2020
View reviewed changes
OskarStark
OskarStark reviewed Dec 7, 2020
View reviewed changes
OskarStark
OskarStark requested changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the link definition of the previous example to the bottom, thanks.

Feel free to ping me afterwards, so I can merge it 👍

@OskarStark OskarStark removed the Waiting Code Merge Docs for features pending to be merged label Dec 7, 2020
@CyberJack
Copy link
Author

CyberJack commented Dec 8, 2020 •
edited
Loading

@OskarStark, I updated the documentation and moved all link definitions to the bottom of the document.

@OskarStark OskarStark force-pushed the 14044-telegram-options branch from 9cee551 to d232aa9 Compare December 8, 2020 11:52
@OskarStark
Copy link
Contributor

Thank you Peter.

@OskarStark OskarStark merged commit 623f146 into symfony:5.2 Dec 8, 2020
@CyberJack CyberJack deleted the 14044-telegram-options branch December 8, 2020 12:37
@javiereguiluz javiereguiluz mentioned this pull request Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[Notifier] added telegram options
5 participants
@CyberJack @OskarStark @wouterj @javiereguiluz @carsonbot