[Routing] Remove simple quotes in config/routes/annotations.yaml #14528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it weird to have both quoted and un-quoted values for `resource:` key in this code block. I went to an actual project to double check the content of `config/routes/annotations.yaml` provided by the recipe (https://github.com/symfony/recipes/blob/master/doctrine/annotations/1.0/config/routes/annotations.yaml) and found out that both `resource:` are unquoted. Versions : 4.4, 5.0, 5.1, 5.2 Have a good day ;)
wouterj
approved these changes
Nov 10, 2020
OskarStark
approved these changes
Nov 12, 2020
|
Thank you Greg ❗ and congrats on your first contribution to the Symfony documentation 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it weird to have both quoted and un-quoted values for
resource:key in this code block.I went to an actual project to double check the content of
config/routes/annotations.yamlprovided by the recipe (https://github.com/symfony/recipes/blob/master/doctrine/annotations/1.0/config/routes/annotations.yaml) and found out that bothresource:are unquoted.Versions : 4.4, 5.0, 5.1, 5.2
Have a good day ;)