Section method only in ConsoleOutputInterface #14550
Conversation
|
Hi @ybenhssaien! Thanks for your PR :) However, I do not agree completely with the changes. Personally, I don't think it's possible to ever get a non- That aside, I think the code you've posted does not work. Later on in the example, |
|
Thanks @wouterj for your feedback, I agree with you about throwing exception rather than my suggestion, and clearly people should receive an instance of This is a test with |
f4c6aa6 to
9cfc356
Compare
|
Thank you @ybenhssaien! I've merged this one in 4.4 (the lowest still maintained version) and made the nr of lines a bit smaller: 73f02f1 (the focus of this example is the usage of console sections, so I kept the exception as small as possible to avoid too much distraction) |
* 4.4: Enhancement: Streamline workflow GitHub Actions: use docker container for CI build Bus restricting with Interfaces Security: add example code which Maker Bundle generated [#14550] Reduce nr of lines used for exception Section method only in ConsoleOutputInterface
* 5.1: Enhancement: Streamline workflow GitHub Actions: use docker container for CI build Bus restricting with Interfaces Security: add example code which Maker Bundle generated [#14550] Reduce nr of lines used for exception Section method only in ConsoleOutputInterface
* 5.2: Enhancement: Streamline workflow GitHub Actions: use docker container for CI build Bus restricting with Interfaces Security: add example code which Maker Bundle generated [#14550] Reduce nr of lines used for exception Section method only in ConsoleOutputInterface
* 5.1: (31 commits) Fix package name for OvhCloud notifier Fix wrong key name Enhancement: Streamline workflow GitHub Actions: use docker container for CI build Bus restricting with Interfaces Security: add example code which Maker Bundle generated [symfony#14550] Reduce nr of lines used for exception Section method only in ConsoleOutputInterface Added a new troubleshooting section in the maintainer guide Removed duplicated line Complete documentation about mailer integration [symfony#14083] Revert mailer.headers option in 4.4 - 5.1 Removed 4.3 versionadded directive [symfony#14565] Minor formatting fixes Updated getParent() description with the why/when (thanks javier!) [Form] Added explicit `getParent()` call in types inheritance mechanism Added PHP types to the DI related articles Added PHP types to the Form related articles Added PHP types to the Doctrine related articles Tweak ...
Since
excecute()accepts an instanceofOutputInterfacewhich doesn't contain the methodsectionwe have to add a check onConsoleOutputInterface