Skip to content

Fix option double dashes #14559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix option double dashes #14559

merged 1 commit into from
Nov 17, 2020

Conversation

ybenhssaien
Copy link
Contributor

The option yell should have double dashes instead none

Copy link
Contributor

@noniagriconomie noniagriconomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can you target v3.4? or v4.4 if 3.4 no more accepts doc fix

@ybenhssaien
Copy link
Contributor Author

The base branch updated on 3.4

@wouterj wouterj added this to the 4.4 milestone Nov 17, 2020
@wouterj
Copy link
Member

wouterj commented Nov 17, 2020

For your information, as 3.4 support ends in just 2 weeks, we have stopped updating the 3.4 branch already (unless major errors exists). But we can change the base to 4.4 during the merge as well, so you don't need to worry about updating it again.

@noniagriconomie
Copy link
Contributor

@wouterj understood, thank you for this clarification :)

@javiereguiluz javiereguiluz changed the base branch from 3.4 to 4.4 November 17, 2020 16:16
@javiereguiluz
Copy link
Member

Thanks! Merged in 4.4 and up.

@javiereguiluz javiereguiluz merged commit ae4663b into symfony:4.4 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants