[DependencyInjection] Removed 3.3 DI changes article #14561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
commented
Nov 17, 2020
| @@ -508,3 +508,4 @@ | |||
| /components/mailer /mailer | |||
| /messenger/message-recorder messenger/dispatch_after_current_bus | |||
| /components/stopwatch https://github.com/symfony/stopwatch | |||
| /service_container/3.3-di-changes https://symfony.com/doc/3.4/service_container/3.3-di-changes.html | |||
There was a problem hiding this comment.
@javiereguiluz can you maybe confirm whether this works?
(I believe the allowed full URLs are github.com and symfony.com, but I'm not sure)
There was a problem hiding this comment.
You are right. I've just double checked and we allow redirects to URL that start with either https://symfony.com/ or https://github.com/
javiereguiluz
approved these changes
Nov 18, 2020
|
Thank you Wouter. |
wouterj
added a commit
that referenced
this pull request
Nov 18, 2020
wouterj
added a commit
that referenced
this pull request
Nov 18, 2020
* 4.4: [#14561] Fixed wrong reference
wouterj
added a commit
that referenced
this pull request
Nov 18, 2020
* 5.1: [#14561] Fixed wrong reference
wouterj
added a commit
that referenced
this pull request
Nov 18, 2020
* 5.2: [#14561] Fixed wrong reference
javiereguiluz
added a commit
that referenced
this pull request
Nov 18, 2020
* '5.2' of github.com:symfony/symfony-docs: [#14561] Fixed wrong reference
This was referenced Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the weirdest article in the documentation and I believe it doesn't make much sense to still have it in the 4.4 or 5.x documentations. If everything works as expected, this article will now redirect to the 3.4 version.