Skip to content

Added config reference for router.default_uri #14651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Added config reference for router.default_uri #14651

merged 1 commit into from
Dec 7, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 4, 2020

This was missing. It is a super great feature =)

@Nyholm Nyholm changed the base branch from 5.x to 5.1 December 4, 2020 11:09
OskarStark
OskarStark reviewed Dec 5, 2020
View reviewed changes
@OskarStark
Copy link
Contributor

Could you find the corresponding code PR and link it here?

Should we add a versionadded directive? @javiereguiluz @wouterj

@Nyholm
Copy link
Member Author

Nyholm commented Dec 5, 2020

It was new in 5.1. It has a dedicated section in the docs, Im not sure it needs a "new in sf51" here too.

Code was introduced here: symfony/symfony#36651

@javiereguiluz javiereguiluz merged commit 1084cb2 into symfony:5.1 Dec 7, 2020
@javiereguiluz
Copy link
Member

Thanks Tobias! Oskar, we added the versionadded directive while merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nyholm @OskarStark @javiereguiluz @wouterj @maxhelias @carsonbot