[Cache] Document cache encryption using SodiumMarshaller #14658
Conversation
ed55af5 to
dad2982
Compare
There was a problem hiding this comment.
Thank you!
I think we can merge both sections by adding a second example, e.g.:
services:
Symfony\Component\Cache\Marshaller\SodiumMarshaller:
decorates: cache.default_marshaller
arguments:
- ['%env(base64:CACHE_DECRYPTION_KEY)%']
# use multiple keys in order to rotate them
#- ['%env(base64:CACHE_DECRYPTION_KEY)%', '%env(base64:OLD_CACHE_DECRYPTION_KEY)%']
- '@Symfony\Component\Cache\Marshaller\SodiumMarshaller.inner'|
Thanks for your suggestions, I appreciate that. I made a few more commits, should I rebase them all into one for a cleaner merge? |
Our merge tool takes care of merging all commits into one before merging the PR. So you don't have to worry about it (but there is nothing stopping you from doing it) |
|
Cool! I'll leave it to your merge tool to do it's thing. I think I could also do a similar PR for #13245. Interested? |
2b5d797 to
4e4924e
Compare
|
Thank you @pableu! This is great 😃 I've fixed @OskarStark comments while merging and also did some more tweaks in 54fdf7a . The diff of that commit looks a bit extreme, I mostly merged some sentences together to make this a little more concise.
Yes, definitely! |
* 5.1: Added the versionadded directive Added config reference for router.default_uri [symfony#14658] Minor tweaks to cache encryption section [Cache] Document cache encryption using SodiumMarshaller
* 5.2: Added the versionadded directive Added config reference for router.default_uri [symfony#14658] Minor tweaks to cache encryption section [Cache] Document cache encryption using SodiumMarshaller
Fix #13070.
I'm no good at doing configs in XML and PHP, but the YAML should be fine.
#SymfonyHackday