Skip to content

[Translator] Updated TranslationInterface import #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Translator] Updated TranslationInterface import #14667

wants to merge 1 commit into from

Conversation

NicolasJourdan
Copy link
Contributor

The current import is : Symfony\Contracts\Translation\TranslationInterface.

In this bloc, I think the needed import is Symfony\Component\Translation\TranslatorInterface

@carsonbot carsonbot changed the title [Translation] Updated TranslationInterface importation [Translator] [Translation] Updated TranslationInterface importation Dec 7, 2020
@NicolasJourdan NicolasJourdan changed the title [Translator] [Translation] Updated TranslationInterface importation [Translator] [Translation] Updated TranslationInterface import Dec 7, 2020
@NicolasJourdan NicolasJourdan changed the title [Translator] [Translation] Updated TranslationInterface import [Translator] Updated TranslationInterface import Dec 7, 2020
@wouterj
Copy link
Member

wouterj commented Dec 9, 2020

Hi @NicolasJourdan! Thanks for taking the time to submit a fix to the documentation.

Unfortunately, I believe this fix is incorrect. The TranslatorInterface was moved from the components to the contracts namespace in Symfony 4.2 (ref symfony/symfony#28210). If you use the version switcher (in the top right corner) to switch to the 4.1 docs (or any docs before 4.2), you can see the components use statement is used: https://symfony.com/doc/4.1/translation#basic-translation

@wouterj wouterj closed this Dec 9, 2020
@NicolasJourdan NicolasJourdan deleted the patch-1 branch December 9, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasJourdan @wouterj @carsonbot